FullStack Developer
Creative thinking
1x
2 Issues Created
2x
16 Issues Created
3x
128 Issues Created
4x
1024 Issues Created
Problem Solving
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Practical/Professional Skills
Communication Skills
1x
100th Community Interaction
2x
1000th Community Interaction
3x
10000th Community Interaction
Collaboration
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Community Engagement
1x
100 Activity Points
2x
1000 Activity Points
3x
10000 Activity Points
Leadership
1x
Promoted to a team leader
Learn How to Learn
1x
Completed the course work
Skills to apply digital & technology solutions
1x
1 Project Completed Successfully
2x
2 Projects Completed Successfully
3x
3 Projects Completed Successfully
Critical Thinking
Autonomy And Responsibility
1x
2 issues identified and resolved
2x
16 issues identified and resolved
3x
128 issues identified and resolved
4x
1024 issues identified and resolved
Empathy
Value inculcation
Multicultural Competence
Individual Skills
Creative thinking
Problem Solving
Practical/Professional Skills
Team Skills
Communication Skills
Collaboration
Community Engagement
Leadership
Learn How to Learn
Skills to apply digital & technology solutions
Critical Thinking
Advanced Skills
Autonomy And Responsibility
Empathy
Value inculcation
Multicultural Competence
Cultural Skills
care_fe/6487
Abdm M3care/1229
Hcx Refactorscare_fe_hcx/3
Hcx/eligibility check workflowteleicu_middleware/62
Added an endpoint to get the time of the last request in observationcare/1093
Added is_occupied field in Bedarike/143
added browser confirmation for uncheduling in Agendaarike/141
Added search bar in Patientsarike/140
Refactored Patients from ruby-html to rescript-reactlife/306
filtered duplicate tweetsShared a comment on a pull request in coronasafe/leaderboard on December 13, 2023 at 5:20:24 AM
@rithviknishad Currently, there is no way to identify the issue number if the issue is linked (connected) using UI, so lets handle that part while moving to Graphql. This is the event created for connection using UI <img width="872" alt="image" src="https://github.com/coronasafe/leaderboard/assets/29787772/31120282-445b-4e9e-9a38-a375c13b9ec6"> If we want to do this now using rest API, we need to iterate through all the open issues and get the cross-referenced event which seems unnecessarily expensive. PS: This is an issue only when the issue is connected with PR in PR's UI and not vice versa.
https://github.com/coronasafe/leaderboard/pull/167#issuecomment-1853285978
Shared a comment on a pull request in coronasafe/leaderboard on December 13, 2023 at 4:58:14 AM
Closed this pr in favour of #155
https://github.com/coronasafe/leaderboard/pull/155#issuecomment-1853270414
Shared a comment on an issue in coronasafe/leaderboard on December 11, 2023 at 6:16:55 AM
@rithviknishad can u assign this to me
https://github.com/coronasafe/leaderboard/issues/153#issuecomment-1849392026
Shared a comment on an issue in coronasafe/leaderboard on December 11, 2023 at 6:16:44 AM
@rithviknishad can u assign this to me
https://github.com/coronasafe/leaderboard/issues/143#issuecomment-1849391843
Shared a comment on an issue in coronasafe/leaderboard on December 10, 2023 at 2:21:24 PM
Yes, that makes sense, then maybe we could just store the number of lines changed for each merged prs, something like ```js { lines: { added: number; removed: number; modified: number; } } ```
https://github.com/coronasafe/leaderboard/issues/144#issuecomment-1848978960
Shared a comment on an issue in coronasafe/leaderboard on December 10, 2023 at 2:08:28 PM
@rithviknishad I think we can accomplish this using `https://api.github.com/repos/{owner}/{repo}/compare/{base}...{head}` API I just wanted to know the use case. Wouldn't adding the file changes to JSON make them heavy over time?
https://github.com/coronasafe/leaderboard/issues/144#issuecomment-1848975903
Shared a comment on a pull request in coronasafe/care_fe on December 7, 2023 at 12:23:11 PM
@Pranshu1902 can you resolve the merge conflicts and wire up the respective backend for this, so that @nihal467 can test it
https://github.com/coronasafe/care_fe/pull/6223#issuecomment-1845249870
Shared a comment on an issue in coronasafe/teleicu_middleware on December 1, 2023 at 3:46:58 PM
Fixed in #117
https://github.com/coronasafe/teleicu_middleware/issues/116#issuecomment-1836335401
Shared a comment on an issue in coronasafe/care_fe on November 30, 2023 at 2:07:06 PM
When the asset was deleted and recreated, the asset uptime started working correctly. Closing this issue as done, incase if this issue persists, feel free to reopen this issue or create a new issue. cc: @nihal467
https://github.com/coronasafe/care_fe/issues/6524#issuecomment-1833848334
Shared a comment on a pull request in coronasafe/care_fe on November 29, 2023 at 11:40:46 AM
> @khavinshankar maybe we can just merge off the configurations for now, and we can eventually migrate existing files as we go? It won't cause functionality issues right other than eslint errors. I agree
https://github.com/coronasafe/care_fe/pull/6557#issuecomment-1831733923
Shared a comment on a pull request in coronasafe/care_fe on November 29, 2023 at 4:53:30 AM
@thedevildude fix the merge conflicts
https://github.com/coronasafe/care_fe/pull/6596#issuecomment-1831215618
Shared a comment on a pull request in coronasafe/care_fe on November 27, 2023 at 2:54:46 PM
Will merge it on Dec 15th (when the feature is no longer supported) cc: @rithviknishad @nihal467
https://github.com/coronasafe/care_fe/pull/6725#issuecomment-1827992492
Shared a comment on a pull request in coronasafe/teleicu_middleware on November 16, 2023 at 2:36:44 AM
@ishanExtreme can you fix the merge conflicts and convert the respective files into ts
https://github.com/coronasafe/teleicu_middleware/pull/107#issuecomment-1813698113
Shared a comment on a pull request in coronasafe/care_fe on November 15, 2023 at 5:57:17 AM
@nihal467 Can you test this pr and list out all the issues (separate them wrt priority)
https://github.com/coronasafe/care_fe/pull/6223#issuecomment-1811854093
Shared a comment on a pull request in coronasafe/care_fe on November 6, 2023 at 12:04:38 PM
ETD: 15th November
https://github.com/coronasafe/care_fe/pull/6223#issuecomment-1794675406
Shared a comment on an issue in coronasafe/care_fe on November 2, 2023 at 9:08:01 AM
@salgra108 I can't seem to reproduce this issue in staging, can you please record a short clip of the process, or snap a screenshot and share it here. cc: @nihal467
https://github.com/coronasafe/care_fe/issues/6534#issuecomment-1790332942
Shared a comment on a pull request in coronasafe/care_fe on October 31, 2023 at 11:17:33 AM
@rithviknishad can you re-review this pr once
https://github.com/coronasafe/care_fe/pull/6515#issuecomment-1787013237
Shared a comment on a pull request in coronasafe/teleicu_middleware on October 30, 2023 at 5:26:11 AM
Closing this pr wrt to #109 cc: @Amanshenoy008 @sainak @gigincg
https://github.com/coronasafe/teleicu_middleware/pull/74#issuecomment-1784506405
Shared a comment on a pull request in coronasafe/teleicu_middleware on October 23, 2023 at 5:49:33 AM
@Amanshenoy008 resolve the merge conflicts
https://github.com/coronasafe/teleicu_middleware/pull/74#issuecomment-1774478074
Shared a comment on a pull request in coronasafe/care_fe on October 19, 2023 at 3:17:02 AM
Hey @thtauhid, just a heads up, skip the ConfigureFacility file, I took care of that in https://github.com/coronasafe/care_fe/pull/6470
https://github.com/coronasafe/care_fe/pull/6452#issuecomment-1769826275
Shared a comment on a pull request in coronasafe/care_fe on October 17, 2023 at 1:06:26 AM
@kshitijv256 resolve the merge conflicts
https://github.com/coronasafe/care_fe/pull/6374#issuecomment-1765495178
Shared a comment on a pull request in coronasafe/care_fe on October 12, 2023 at 3:53:13 AM
@nihal467 I think the errors are fixed, can you recheck this cc: @shyamprakash123 @rithviknishad
https://github.com/coronasafe/care_fe/pull/6344#issuecomment-1758870756
Shared a comment on a pull request in coronasafe/care_fe on October 11, 2023 at 2:03:37 PM
@Omkar76 make the necessary changes suggested by Bodhi
https://github.com/coronasafe/care_fe/pull/6415#issuecomment-1757767174
Shared a comment on a pull request in coronasafe/care_fe on October 10, 2023 at 3:09:29 PM
@nihal467 the changes looks good, just give it a general test of all the graphs
https://github.com/coronasafe/care_fe/pull/6424#issuecomment-1755653956
Shared a comment on a pull request in coronasafe/care_fe on October 10, 2023 at 3:07:55 PM
@nihal467 the changes looks good, just give it a general test of above mentioned files
https://github.com/coronasafe/care_fe/pull/6415#issuecomment-1755651080
Shared a comment on a pull request in coronasafe/care_fe on October 10, 2023 at 6:14:17 AM
@rithviknishad @sainak can you review this pr once, we'll go ahead with this pr for now and update and keep the original issue open to remove this dependency
https://github.com/coronasafe/care_fe/pull/6415#issuecomment-1754469915
Shared a comment on a pull request in coronasafe/care_fe on October 9, 2023 at 10:48:02 AM
@nihal467 can you just test the feed in this deploy preview, LGTM, no breaking changes
https://github.com/coronasafe/care_fe/pull/6317#issuecomment-1752774627
Shared a comment on a pull request in coronasafe/care_fe on October 4, 2023 at 4:35:15 AM
@rithviknishad can you re-review this once
https://github.com/coronasafe/care_fe/pull/6338#issuecomment-1746119830
Shared a comment on an issue in coronasafe/care_fe on September 26, 2023 at 10:06:31 AM
This issue is tracked in different pr https://github.com/coronasafe/care_fe/issues/6280 cc: @nihal467 @rithviknishad
https://github.com/coronasafe/care_fe/issues/6141#issuecomment-1735231168
Shared a comment on a pull request in coronasafe/care_fe on September 26, 2023 at 9:57:11 AM
@rithviknishad can u re-review this once
https://github.com/coronasafe/care_fe/pull/6338#issuecomment-1735216624
Shared a comment on a pull request in coronasafe/care_fe on September 25, 2023 at 4:22:16 AM
@nihal467 About the Offline status, we won't be able to see that status because the feed will always try to reconnect, this is an intentional behavior.
https://github.com/coronasafe/care_fe/pull/4575#issuecomment-1732883986
Shared a comment on an issue in coronasafe/care_fe on September 22, 2023 at 9:01:32 AM
@thtauhid check this pr (https://github.com/coronasafe/care_fe/pull/6286) in which the auto-reset feature is implemented for the patient consultation feed page, same functionality is required in the feed of the asset config page. cc: @nihal467
https://github.com/coronasafe/care_fe/issues/6322#issuecomment-1731069613
Shared a comment on an issue in coronasafe/care_fe on September 22, 2023 at 6:23:22 AM
above mentioned issues will be tracked as separate issues
https://github.com/coronasafe/care_fe/issues/6294#issuecomment-1730868153
Shared a comment on a pull request in coronasafe/care_fe on September 11, 2023 at 1:49:27 PM
@rithviknishad can you re-review this once
https://github.com/coronasafe/care_fe/pull/6238#issuecomment-1713928456
Shared a comment on a pull request in coronasafe/care_fe on September 11, 2023 at 8:28:48 AM
@thtauhid is this a duplicate pr of https://github.com/coronasafe/care_fe/pull/6258
https://github.com/coronasafe/care_fe/pull/6232#issuecomment-1713413286
Shared a comment on an issue in coronasafe/care_fe on September 11, 2023 at 5:14:15 AM
done
https://github.com/coronasafe/care_fe/issues/6207#issuecomment-1713178130
Shared a comment on a pull request in coronasafe/care_fe on September 8, 2023 at 4:33:11 AM
@nihal467 the cypress is failing, can you give it a another look
https://github.com/coronasafe/care_fe/pull/6135#issuecomment-1711059994
Shared a comment on an issue in coronasafe/care on September 5, 2023 at 2:24:41 PM
Will follow up on this after ABDM m3 is done. cc: @sainak @Ashesh3
https://github.com/coronasafe/care/issues/1578#issuecomment-1706725877
Shared a comment on a pull request in coronasafe/care_fe on September 5, 2023 at 9:58:23 AM
- Separated out linking health facility in care and registering it as a service in ABDM - Added UI to show if the health facility is registered as a service <img width="1124" alt="image" src="https://github.com/coronasafe/care_fe/assets/29787772/51127217-8ea1-408d-adb7-3a92cd5030df">
https://github.com/coronasafe/care_fe/pull/6197#issuecomment-1706312537
Shared a comment on a pull request in coronasafe/ayushma on September 5, 2023 at 4:02:31 AM
@Ashesh3 @skks1212 all done, can you guys review this once along with frontend (https://github.com/coronasafe/ayushma_fe/pull/54)
https://github.com/coronasafe/ayushma/pull/194#issuecomment-1705914647
Shared a comment on a pull request in coronasafe/care_fe on September 1, 2023 at 5:03:10 AM
@aparnacoronasafe Even if the health facility configuration is directly exposed, we still need production keys for the linking of the health facility to work, because when we link a health facility, we are calling ABDM bridge API in the backend which requires prod keys. Is this pr still relevant?
https://github.com/coronasafe/care_fe/pull/6197#issuecomment-1702162051
Shared a comment on a pull request in coronasafe/care_fe on August 9, 2023 at 11:38:21 AM
@rithviknishad @Ashesh3 can you please review this pr once
https://github.com/coronasafe/care_fe/pull/6003#issuecomment-1671164702
Shared a comment on an issue in coronasafe/care_fe on August 2, 2023 at 7:50:21 AM
@nihal467 will take care of this issue in the coming week
https://github.com/coronasafe/care_fe/issues/3449#issuecomment-1661688731
Shared a comment on an issue in coronasafe/teleicu_middleware on July 31, 2023 at 12:27:34 PM
Resolved in https://github.com/coronasafe/teleicu_middleware/pull/76
https://github.com/coronasafe/teleicu_middleware/issues/61#issuecomment-1658275202
Shared a comment on a pull request in coronasafe/care_fe on July 18, 2023 at 6:52:29 AM
@rithviknishad is this relevant?
https://github.com/coronasafe/care_fe/pull/5682#issuecomment-1639606054
Shared a comment on an issue in coronasafe/care_fe on July 18, 2023 at 6:47:51 AM
This issue has been resolved
https://github.com/coronasafe/care_fe/issues/5646#issuecomment-1639601467
Shared a comment on an issue in coronasafe/care_fe on July 18, 2023 at 6:45:47 AM
@mustafaazad03 any progress on this issue?
https://github.com/coronasafe/care_fe/issues/5695#issuecomment-1639599077
Shared a comment on a pull request in coronasafe/care_fe on July 18, 2023 at 6:39:31 AM
@rithviknishad can you review this again
https://github.com/coronasafe/care_fe/pull/5838#issuecomment-1639592693
Shared a comment on a pull request in coronasafe/care_fe on July 13, 2023 at 9:21:52 AM
@mathew-alex can you review this and merge it
https://github.com/coronasafe/care_fe/pull/5831#issuecomment-1633879837
Shared a comment on a pull request in coronasafe/ayushma_fe on July 3, 2023 at 7:11:43 AM
@skks1212 I'm not able to see the vercel logs, can u add me in that or can u take a screenshot and post it here
https://github.com/coronasafe/ayushma_fe/pull/54#issuecomment-1617502440
Shared a comment on a pull request in coronasafe/ayushma_fe on July 3, 2023 at 7:10:36 AM
> @khavinshankar > > * All is perfect, just the page is reloading after submit. > * Can we have regular icons for thumbs up/down? `far` instead or `fal`. Also they don't have a `cursor-pointer` > * If a popup opens after hovering on the given feedback icon containing the message it would be nice. > ![image](https://user-images.githubusercontent.com/23238460/250278826-1023866b-2018-4415-a2bb-9e0557920c70.png) > * Deploy preview is failing can you look into it? - [x] added a state instead of reloading the page - [x] changed fal to far, and added cursor pointer - [x] added a tooltip for feedback messages on hover <img width="1179" alt="image" src="https://github.com/coronasafe/ayushma_fe/assets/29787772/77728e96-d379-4ff4-80b4-b1e5bc5929b7">
https://github.com/coronasafe/ayushma_fe/pull/54#issuecomment-1617500704
Shared a comment on a pull request in coronasafe/care_fe on June 30, 2023 at 5:42:25 AM
Fixed the positioning of location picker <img width="1469" alt="image" src="https://github.com/coronasafe/care_fe/assets/29787772/c8323f99-b59d-462c-8ec7-f6b403c6e1ff"> cc: @nihal467 @print-Sathvik
https://github.com/coronasafe/care_fe/pull/5719#issuecomment-1614157268
Shared a comment on an issue in coronasafe/care_fe on June 30, 2023 at 4:35:05 AM
@sainak @nihal467 what's the issue with PWA, is anything in specific that is not working?
https://github.com/coronasafe/care_fe/issues/5783#issuecomment-1614106212
Shared a comment on a pull request in coronasafe/care_fe on June 21, 2023 at 6:59:39 AM
@Ashesh3 @rithviknishad can you review this pr again
https://github.com/coronasafe/care_fe/pull/5641#issuecomment-1600288156
Shared a comment on a pull request in coronasafe/care on June 20, 2023 at 9:45:26 AM
@vigneshhari moved sensitive data into envs, and no need to worry about the data, it's just an HCX staging server details
https://github.com/coronasafe/care/pull/1390#issuecomment-1598458885
Shared a comment on a pull request in coronasafe/care_fe on June 13, 2023 at 11:29:18 AM
@mathew-alex can you look into this, in forked repo prs the add label is failing
https://github.com/coronasafe/care_fe/pull/5623#issuecomment-1589114184
Shared a comment on a pull request in coronasafe/care_fe on June 13, 2023 at 10:04:48 AM
@nihal467 can u review and approve this pr
https://github.com/coronasafe/care_fe/pull/5632#issuecomment-1588976534
Shared a comment on a pull request in coronasafe/care_fe on June 13, 2023 at 9:39:42 AM
> @khavinshankar we could squash the 4 steps of remove and add labels by using multiple labels at once to 2 steps right? > > ``` > with: > labels: | > label-1 > label-2 > ``` > > https://github.com/actions-ecosystem/action-remove-labels#remove-multiple-labels-with-a-comment @rithviknishad but the if logic is different here
https://github.com/coronasafe/care_fe/pull/5652#issuecomment-1588932295
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2023 at 5:15:37 AM
@JahnabDutta can you also fix the cypress tests ![image](https://github.com/coronasafe/care_fe/assets/29787772/3f3d07e3-d7ed-44fe-82ac-a04415a179ef) check this action for the failing tests https://github.com/coronasafe/care_fe/actions/runs/5142676229/jobs/9263088413?pr=5572
https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1573166464
Shared a comment on an issue in coronasafe/care_fe on May 27, 2023 at 3:29:00 AM
@ShivamJhaa try all these formats - "919994565656" - "+919994565656" - "+91 9994565656" - "+91 99945-65656" one of these might work. @GokulramGHV can you help @ShivamJhaa out
https://github.com/coronasafe/care_fe/issues/4233#issuecomment-1565185581
Shared a comment on an issue in coronasafe/care_fe on May 24, 2023 at 7:08:48 AM
@ShivamJhaa Yes, when you see a stale issue you are interested in, feel free to ask about the status of the issue tagging the assignees, if no one responds you can pick it up. And about the stale issue, you are talking about (https://github.com/coronasafe/care_fe/issues/4233), yes you can work on it
https://github.com/coronasafe/care_fe/issues/4133#issuecomment-1560567734
Shared a comment on an issue in coronasafe/care_fe on May 22, 2023 at 2:29:53 PM
Hey @gayan-au, is the filter only for getting the count of patients or does it have any other uses? If it is only for the count, we could add a block or card in metabase (dashboard) cc: @nihal467
https://github.com/coronasafe/care_fe/issues/5474#issuecomment-1557325529
Shared a comment on a pull request in coronasafe/care_fe on May 18, 2023 at 2:07:47 PM
@cp-Coder still the cypress workflow is failing, isn't this pr addressing that?
https://github.com/coronasafe/care_fe/pull/5469#issuecomment-1553115881
Shared a comment on a pull request in coronasafe/care_fe on May 9, 2023 at 7:43:58 AM
@ cp-Coder seems there are no changes in code, some other pr might have handled it. So closing this pr, feel free to open it if needed. cc: @nihal467
https://github.com/coronasafe/care_fe/pull/5348#issuecomment-1539619884
Shared a comment on a pull request in coronasafe/care_fe on May 9, 2023 at 7:39:18 AM
@rithviknishad can you rereview this once
https://github.com/coronasafe/care_fe/pull/5443#issuecomment-1539614474
Shared a comment on a pull request in coronasafe/care_fe on May 2, 2023 at 12:15:43 PM
@patelaryan7751 can you please clear out the merge conflict as soon as possible
https://github.com/coronasafe/care_fe/pull/5043#issuecomment-1531369471
Shared a comment on an issue in coronasafe/care_fe on April 26, 2023 at 6:34:03 AM
@rithviknishad any updates on this?
https://github.com/coronasafe/care_fe/issues/5384#issuecomment-1522861754
Shared a comment on an issue in coronasafe/care_fe on April 25, 2023 at 12:58:10 PM
@GokulramGHV any updates on this
https://github.com/coronasafe/care_fe/issues/5401#issuecomment-1521746859
Shared a comment on an issue in coronasafe/care_fe on April 25, 2023 at 8:01:31 AM
@aparnacoronasafe @nihal467 When a patient is admitted within care, aren't the previous consultations automatically available?
https://github.com/coronasafe/care_fe/issues/5399#issuecomment-1521341577
Shared a comment on an issue in coronasafe/care_fe on April 25, 2023 at 7:28:41 AM
@GokulramGHV In this, there is another case, if the patient is discharged with EXP (expired) as the cause, move the shifting request automatically to patient expired. cc: @aparnacoronasafe
https://github.com/coronasafe/care_fe/issues/5401#issuecomment-1521284688
Shared a comment on a pull request in coronasafe/care_fe on April 21, 2023 at 1:10:13 PM
cc: @sainak
https://github.com/coronasafe/care_fe/pull/5369#issuecomment-1517815137
Shared a comment on a pull request in coronasafe/care_fe on April 13, 2023 at 6:04:45 AM
@GokulramGHV can you check if this pr is still relevant now?
https://github.com/coronasafe/care_fe/pull/4236#issuecomment-1506396462
Shared a comment on a pull request in coronasafe/care_fe on April 13, 2023 at 6:03:49 AM
@GokulramGHV can you clear the merge conflicts, I'll review this and merge it
https://github.com/coronasafe/care_fe/pull/4134#issuecomment-1506395470
Shared a comment on a pull request in coronasafe/care_fe on April 13, 2023 at 6:02:41 AM
@nihal467 Is this pr relevant now? @cp-Coder what's the status of this pr?
https://github.com/coronasafe/care_fe/pull/3799#issuecomment-1506393778
Shared a comment on a pull request in coronasafe/care_fe on April 13, 2023 at 6:01:11 AM
closing it, was just an experimental feature
https://github.com/coronasafe/care_fe/pull/4066#issuecomment-1506392293
Shared a comment on a pull request in coronasafe/care_fe on April 12, 2023 at 5:44:44 AM
LGTM, @mathew-alex can you review this once and merge it
https://github.com/coronasafe/care_fe/pull/5204#issuecomment-1504686732
Shared a comment on a pull request in coronasafe/care_fe on April 5, 2023 at 4:20:07 AM
@rithviknishad can you clear out merge conflicts
https://github.com/coronasafe/care_fe/pull/5158#issuecomment-1496897176
Shared a comment on a pull request in coronasafe/care_fe on April 5, 2023 at 3:55:51 AM
@rithviknishad can you rereview this pr
https://github.com/coronasafe/care_fe/pull/5202#issuecomment-1496884338
Shared a comment on a pull request in coronasafe/care_fe on April 3, 2023 at 5:28:16 AM
@sainak can you fix the merge conflicts
https://github.com/coronasafe/care_fe/pull/5140#issuecomment-1493685960
Shared a comment on a pull request in coronasafe/care_fe on March 20, 2023 at 4:21:46 AM
already merged #5108
https://github.com/coronasafe/care_fe/pull/4843#issuecomment-1475603348
Shared a comment on a pull request in coronasafe/care_fe on March 20, 2023 at 4:20:18 AM
already merged (#5108)
https://github.com/coronasafe/care_fe/pull/5107#issuecomment-1475602700
Shared a comment on a pull request in coronasafe/care on March 14, 2023 at 3:13:36 PM
@nihal467 had a huddle with @cp-Coder, everything is working fine, and there was no error, I passed in the PatientRegistration model inside PatientConsultationSerializer @gigincg @vigneshhari can you review this and merge it
https://github.com/coronasafe/care/pull/1073#issuecomment-1468294850
Shared a comment on a pull request in coronasafe/care on March 14, 2023 at 2:32:36 PM
@cp-Coder To Reproduce the above issue, Step 1: Clone the repo `git clone git@github.com:coronasafe/care_fe.git` Step 2: Run the app `sudo make up` Step 3: Seed dummy data `sudo docker exec care python3 manage.py load_dummy_data` Step 4: Pull the changes from this pr `gh pr checkout 1073` Step 5: Migrate the data, `sudo docker exec care python3 manage.py migrate` Step 6: Try serializing patient instance in django shell `sudo docker exec -it care python3 manage.py shell` ```py from care.facility.models.patient import PatientRegistration from care.facility.api.serializers import PatientDetailsSerializer PatientDetailsSerializer(PatientRegistration.objects.first()) ``` cc: @gigincg
https://github.com/coronasafe/care/pull/1073#issuecomment-1468212465
Shared a comment on a pull request in coronasafe/care on March 14, 2023 at 12:11:36 PM
@cp-Coder I'm getting this error, after migration, ![image](https://user-images.githubusercontent.com/29787772/224997107-5d64df53-1d96-4d9d-bf62-3ac5ed976ddd.png)
https://github.com/coronasafe/care/pull/1073#issuecomment-1467988670
Shared a comment on a pull request in coronasafe/care_fe on March 13, 2023 at 8:46:01 AM
@ayushjnv1 can you please resolve the merge conflicts
https://github.com/coronasafe/care_fe/pull/5062#issuecomment-1465727729
Shared a comment on a pull request in coronasafe/care_fe on March 6, 2023 at 3:34:57 AM
![image](https://user-images.githubusercontent.com/29787772/223013686-a18898b4-c355-411a-a19a-1fe05a6da701.png) @nihal467 can you retest this with a hard refresh or in incognito, it's working on my end.
https://github.com/coronasafe/care_fe/pull/4575#issuecomment-1455389020
Shared a comment on a pull request in coronasafe/care_fe on February 27, 2023 at 9:58:11 AM
@cp-Coder can you work on the merge conflits ASAP
https://github.com/coronasafe/care_fe/pull/3987#issuecomment-1446031668
Shared a comment on a pull request in coronasafe/care_fe on February 27, 2023 at 8:27:58 AM
@rithviknishad can you rereview this
https://github.com/coronasafe/care_fe/pull/4765#issuecomment-1445904040
Shared a comment on an issue in coronasafe/care_fe on February 25, 2023 at 7:57:17 AM
new more detailed issues will be created
https://github.com/coronasafe/care_fe/issues/2079#issuecomment-1445024783
Shared a comment on a pull request in coronasafe/care_fe on February 25, 2023 at 6:44:01 AM
will create a new pr
https://github.com/coronasafe/care_fe/pull/4070#issuecomment-1445012581
Shared a comment on a pull request in coronasafe/care_fe on February 14, 2023 at 5:46:30 AM
@rithviknishad can you fix these merge conflicts
https://github.com/coronasafe/care_fe/pull/4740#issuecomment-1429154960
Shared a comment on a pull request in coronasafe/care_fe on February 13, 2023 at 6:01:51 AM
outdated, not relevant
https://github.com/coronasafe/care_fe/pull/3360#issuecomment-1427393373
Shared a comment on a pull request in coronasafe/care_fe on February 13, 2023 at 6:01:51 AM
outdated, not relevant
https://github.com/coronasafe/care_fe/pull/3360#issuecomment-1427393373
Shared a comment on a pull request in coronasafe/care_fe on February 8, 2023 at 1:33:04 PM
@cp-Coder can you work on @rithviknishad's comments
https://github.com/coronasafe/care_fe/pull/4495#issuecomment-1422607546
Shared a comment on a pull request in coronasafe/care_fe on February 8, 2023 at 1:26:29 PM
putting it on hold as this is just a refactor
https://github.com/coronasafe/care_fe/pull/3307#issuecomment-1422599193
Shared a comment on a pull request in coronasafe/care_fe on February 8, 2023 at 1:14:08 PM
@Ashesh3 initially we were using string and later we changed it to an array, so is that factored in?
https://github.com/coronasafe/care_fe/pull/2536#issuecomment-1422582193
Shared a comment on a pull request in coronasafe/care_fe on February 8, 2023 at 1:10:55 PM
@rithviknishad can you rereview this
https://github.com/coronasafe/care_fe/pull/4495#issuecomment-1422577686
Shared a comment on a pull request in coronasafe/care_fe on February 8, 2023 at 7:28:12 AM
@rithviknishad can u rereview this
https://github.com/coronasafe/care_fe/pull/3637#issuecomment-1422146094
Shared a comment on an issue in coronasafe/care_fe on February 6, 2023 at 10:55:17 AM
@cp-Coder can you please work on this immediately and push a pr ASAP, this needs to be released in this week's release cc: @nihal467
https://github.com/coronasafe/care_fe/issues/4697#issuecomment-1418887662
Shared a comment on an issue in coronasafe/care_fe on February 6, 2023 at 10:55:17 AM
@cp-Coder can you please work on this immediately and push a pr ASAP, this needs to be released in this week's release cc: @nihal467
https://github.com/coronasafe/care_fe/issues/4697#issuecomment-1418887662
Shared a comment on a pull request in coronasafe/care on February 5, 2023 at 3:57:33 PM
@vigneshhari we don't actually give any API for the users to add any skills, This is the first time we are adding skills, will this still be a problem?
https://github.com/coronasafe/care/pull/1176#issuecomment-1418079638
Shared a comment on an issue in coronasafe/care_fe on February 5, 2023 at 2:23:13 PM
The users are not showing up in the doctor connect as they don't have whatsapp number (alternate_phone_number) mentioned. As this is an expected feature, closing this issue. A thought to improve UX, maybe we can also show the users without alternate number disabled and grayed out sorted to the end of the list cc: @nihal467 @aparnacoronasafe
https://github.com/coronasafe/care_fe/issues/4760#issuecomment-1417962416
Shared a comment on a pull request in coronasafe/care_fe on February 3, 2023 at 2:55:47 PM
@nihal467 can you retest this, fixed the issue ![image](https://user-images.githubusercontent.com/29787772/216634502-79684ded-2463-4599-bd38-50f4dc8a8e85.png)
https://github.com/coronasafe/care_fe/pull/4595#issuecomment-1415986846
Shared a comment on a pull request in coronasafe/care_fe on February 3, 2023 at 7:18:35 AM
@nihal467 can you retest this pr
https://github.com/coronasafe/care_fe/pull/4455#issuecomment-1415203622
Shared a comment on a pull request in coronasafe/care_fe on February 3, 2023 at 5:33:16 AM
@Pragati1610 any reasons for force pushing?
https://github.com/coronasafe/care_fe/pull/4455#issuecomment-1415021316
Shared a comment on a pull request in coronasafe/care_fe on January 28, 2023 at 1:34:01 AM
@nihal467 as this is a minor issue that removes the state logo from preview deploys, I'll merge this one without testing cc: @rithviknishad
https://github.com/coronasafe/care_fe/pull/4686#issuecomment-1407245552
Shared a comment on a pull request in coronasafe/care_fe on January 25, 2023 at 5:08:21 AM
@rithviknishad I believe that this was already discussed in the EOD (the color invention ...) and was approved, right? cc: @nihal467
https://github.com/coronasafe/care_fe/pull/4627#issuecomment-1403103736
Shared a comment on an issue in coronasafe/care_fe on January 18, 2023 at 6:30:56 AM
closing this as resolved
https://github.com/coronasafe/care_fe/issues/1045#issuecomment-1386556545
Shared a comment on an issue in coronasafe/care_fe on January 18, 2023 at 6:00:59 AM
@cp-Coder whats the status of this issue?
https://github.com/coronasafe/care_fe/issues/4486#issuecomment-1386532810
Shared a comment on a pull request in coronasafe/care_fe on January 17, 2023 at 9:33:07 AM
@rithviknishad can you rereview this pr
https://github.com/coronasafe/care_fe/pull/4432#issuecomment-1385095650
Shared a comment on a pull request in coronasafe/care_fe on January 17, 2023 at 9:27:29 AM
@rithviknishad can you rereview this one
https://github.com/coronasafe/care_fe/pull/4583#issuecomment-1385086069
Shared a comment on an issue in coronasafe/care_fe on January 14, 2023 at 1:10:12 PM
@nihal467 'll push a fix this week
https://github.com/coronasafe/care_fe/issues/4449#issuecomment-1382734226
Shared a comment on an issue in coronasafe/care on January 12, 2023 at 2:57:43 PM
transferring this issue back to the front-end cc: @nihal467
https://github.com/coronasafe/care/issues/1153#issuecomment-1380501112
Shared a comment on a pull request in coronasafe/care_fe on January 11, 2023 at 12:01:44 PM
@skks1212 can you rereview this one
https://github.com/coronasafe/care_fe/pull/4549#issuecomment-1378645285
Shared a comment on an issue in coronasafe/care_fe on January 11, 2023 at 6:19:49 AM
tracked in new issue https://github.com/coronasafe/care_fe/issues/4559
https://github.com/coronasafe/care_fe/issues/4302#issuecomment-1378289988
Shared a comment on a pull request in coronasafe/care_fe on January 10, 2023 at 6:29:42 AM
@nihal467 fixed the country code error, can you check it out cc: @skks1212
https://github.com/coronasafe/care_fe/pull/4547#issuecomment-1376793191
Shared a comment on a pull request in coronasafe/care_fe on January 9, 2023 at 2:30:52 PM
@Pragati1610 this doesn't seem relevant anymore, if the issue persists, feel free to reopen it or create a new pr
https://github.com/coronasafe/care_fe/pull/3467#issuecomment-1375709951
Shared a comment on an issue in coronasafe/care_fe on January 9, 2023 at 2:30:09 PM
@ishanExtreme this doesn't seem relevant anymore, if the issue persists, feel free to reopen it or create a new issue
https://github.com/coronasafe/care_fe/issues/2454#issuecomment-1375708941
Shared a comment on a pull request in coronasafe/care_fe on January 9, 2023 at 11:46:39 AM
this feature has already been added
https://github.com/coronasafe/care_fe/pull/3356#issuecomment-1375506307
Shared a comment on an issue in coronasafe/care_fe on January 6, 2023 at 1:15:40 PM
Acknowledged
https://github.com/coronasafe/care_fe/issues/4528#issuecomment-1373611103
Shared a comment on a pull request in coronasafe/care_fe on January 5, 2023 at 6:55:59 AM
@rabilrbl I have pushed a solution for this https://github.com/coronasafe/care_fe/pull/4513 cc: @nihal467
https://github.com/coronasafe/care_fe/pull/4471#issuecomment-1371847115
Shared a comment on a pull request in coronasafe/care_fe on January 5, 2023 at 5:14:04 AM
@rithviknishad can you rereview this one
https://github.com/coronasafe/care_fe/pull/4226#issuecomment-1371791384
Shared a comment on a pull request in coronasafe/care_fe on January 4, 2023 at 2:39:19 PM
@skks1212 the remaining failing cypress tests should be fixed once auto-update is merged, so can you just handle the merge conflicts cc: @nihal467
https://github.com/coronasafe/care_fe/pull/4159#issuecomment-1371011514
Shared a comment on an issue in coronasafe/care_fe on January 4, 2023 at 8:12:08 AM
This was reopened by mistake
https://github.com/coronasafe/care_fe/issues/2007#issuecomment-1370600049
Shared a comment on a pull request in coronasafe/care_fe on January 3, 2023 at 8:12:50 AM
@cp-Coder fix the failing cypress tests
https://github.com/coronasafe/care_fe/pull/4466#issuecomment-1369486503
Shared a comment on a pull request in coronasafe/care_fe on January 3, 2023 at 5:49:20 AM
@cp-Coder checkout the failing cypress tests
https://github.com/coronasafe/care_fe/pull/4427#issuecomment-1369414720
Shared a comment on a pull request in coronasafe/care_fe on January 3, 2023 at 5:48:38 AM
@cp-Coder checkout the failing cypress tests
https://github.com/coronasafe/care_fe/pull/4416#issuecomment-1369414503
Shared a comment on a pull request in coronasafe/care_fe on January 3, 2023 at 5:46:27 AM
@GokulramGHV checkout the failing cypress tests
https://github.com/coronasafe/care_fe/pull/4439#issuecomment-1369413848
Shared a comment on a pull request in coronasafe/care_fe on January 3, 2023 at 5:44:06 AM
@cp-Coder do check the cypress tests
https://github.com/coronasafe/care_fe/pull/4378#issuecomment-1369413039
Shared a comment on an issue in coronasafe/care_fe on December 29, 2022 at 4:17:41 AM
@patelaryan7751 what's the status of this issue
https://github.com/coronasafe/care_fe/issues/4139#issuecomment-1367062339
Shared a comment on a pull request in coronasafe/care_fe on December 28, 2022 at 11:32:08 AM
@cp-Coder can you take off the failing cypress tests, most likely merging the latest develop branch should fix it
https://github.com/coronasafe/care_fe/pull/4427#issuecomment-1366584205
Shared a comment on a pull request in coronasafe/care_fe on December 28, 2022 at 4:59:24 AM
@skks1212 can you take off the failing cypress tests, most likely merging the latest develop branch should fix it
https://github.com/coronasafe/care_fe/pull/4159#issuecomment-1366368861
Shared a comment on a pull request in coronasafe/care_fe on December 28, 2022 at 4:55:52 AM
@cp-Coder can you take off the failing cypress tests, most likely merging the latest develop branch should fix it
https://github.com/coronasafe/care_fe/pull/4416#issuecomment-1366367781
Shared a comment on an issue in coronasafe/care_fe on December 28, 2022 at 4:51:55 AM
Acknowledged
https://github.com/coronasafe/care_fe/issues/4433#issuecomment-1366366556
Shared a comment on an issue in coronasafe/care_fe on December 28, 2022 at 4:48:42 AM
@rithviknishad as a follow-up to this issue, can you make an epic issue that tracks multiple issues for adding localization support across the platform for all hardcoded string
https://github.com/coronasafe/care_fe/issues/4423#issuecomment-1366365494
Shared a comment on a pull request in coronasafe/care_fe on December 27, 2022 at 4:32:45 AM
@nihal467 can please you retest this, seems to be working
https://github.com/coronasafe/care_fe/pull/4034#issuecomment-1365605117
Shared a comment on a pull request in coronasafe/care_fe on December 26, 2022 at 1:40:48 PM
@nihal467 can you retest this pr again, changes have been made
https://github.com/coronasafe/care_fe/pull/4377#issuecomment-1365198684
Shared a comment on a pull request in coronasafe/care_fe on December 26, 2022 at 1:38:21 PM
@cp-Coder seems there are failing tests, please do check
https://github.com/coronasafe/care_fe/pull/4378#issuecomment-1365195902
Shared a comment on an issue in coronasafe/care_fe on December 25, 2022 at 11:14:39 AM
@rithviknishad even when we set a `min width`, there are chances that if the content is bigger then we would have inconsistencies
https://github.com/coronasafe/care_fe/issues/4349#issuecomment-1364664735
Shared a comment on an issue in coronasafe/care_fe on December 24, 2022 at 10:14:22 AM
should be fixed by https://github.com/coronasafe/care/pull/1136
https://github.com/coronasafe/care_fe/issues/4398#issuecomment-1364503448
Shared a comment on a pull request in coronasafe/care_fe on December 23, 2022 at 6:42:34 AM
LGTM
https://github.com/coronasafe/care_fe/pull/4307#issuecomment-1363666543
Shared a comment on a pull request in coronasafe/care_fe on December 22, 2022 at 5:22:56 PM
@nihal467 I have made a pr https://github.com/coronasafe/care/pull/1127 in the backend related to the above-mentioned issue, once that is merged this pr can be tested.
https://github.com/coronasafe/care_fe/pull/4357#issuecomment-1363135748
Shared a comment on a pull request in coronasafe/care_fe on December 22, 2022 at 2:57:30 PM
@nihal467 the above-mentioned error is from the backend. In the backend, it is still using `asset.meta.middleware_hostname` _get_url function in the image_ ![image](https://user-images.githubusercontent.com/29787772/209161227-b66c7e28-c21a-4f90-800f-100193536267.png)
https://github.com/coronasafe/care_fe/pull/4357#issuecomment-1362937664
Shared a comment on a pull request in coronasafe/care_fe on December 22, 2022 at 1:42:50 PM
@rithviknishad can you checkout the merge conflict
https://github.com/coronasafe/care_fe/pull/4358#issuecomment-1362854679
Shared a comment on a pull request in coronasafe/care_fe on December 22, 2022 at 12:32:47 PM
@Pranshu1902 clear the failing cypress tests
https://github.com/coronasafe/care_fe/pull/4324#issuecomment-1362785332
Shared a comment on a pull request in coronasafe/care_fe on December 22, 2022 at 11:53:03 AM
@cp-Coder do fix the failing cypress tests
https://github.com/coronasafe/care_fe/pull/4378#issuecomment-1362750332
Shared a comment on an issue in coronasafe/care_fe on December 22, 2022 at 10:02:39 AM
@Pranshu1902 yes that would be nice, for totals instead of having a separate card, we could show it near the title greyed out @nihal467 your thoughts
https://github.com/coronasafe/care_fe/issues/4389#issuecomment-1362641884
Shared a comment on a pull request in coronasafe/care_fe on December 22, 2022 at 4:27:40 AM
@nihal467 can you retest this pr
https://github.com/coronasafe/care_fe/pull/4324#issuecomment-1362397101
Shared a comment on a pull request in coronasafe/care_fe on December 21, 2022 at 5:55:21 AM
@GokulramGHV can you checkout the cypress fails, likely merging the develop branch should fix it
https://github.com/coronasafe/care_fe/pull/4134#issuecomment-1360888390
Shared a comment on a pull request in coronasafe/care_fe on December 21, 2022 at 5:11:21 AM
@cp-Coder @kunatastic can you checkout the cypress fails, likely merging the develop branch should fix it
https://github.com/coronasafe/care_fe/pull/3987#issuecomment-1360867308
Shared a comment on a pull request in coronasafe/care_fe on December 21, 2022 at 5:02:46 AM
@Pranshu1902 the functionality works well, but can you polish the UI! my suggestion would be, to have an eye icon that can be toggled, and also have a max width for the facilities and make it scrollable feel free to bring this up in an EOD call cc: @nihal467
https://github.com/coronasafe/care_fe/pull/4324#issuecomment-1360861599
Shared a comment on a pull request in coronasafe/care_fe on December 21, 2022 at 4:58:26 AM
@Ashesh3 can you checkout the cypress fails, likely merging the develop branch should fix it
https://github.com/coronasafe/care_fe/pull/4329#issuecomment-1360859103
Shared a comment on a pull request in coronasafe/care_fe on December 21, 2022 at 4:55:49 AM
@Ashesh3 can you checkout the cypress fails, likely merging the develop branch should fix it
https://github.com/coronasafe/care_fe/pull/4355#issuecomment-1360857983
Shared a comment on an issue in coronasafe/care_fe on December 19, 2022 at 12:57:50 PM
@rithviknishad something of that sort
https://github.com/coronasafe/care_fe/issues/4353#issuecomment-1357625237
Shared a comment on an issue in coronasafe/care_fe on December 19, 2022 at 12:26:59 PM
@rithviknishad The jumping around seems to be caused because of the useExport hook. We are exporting ExportMenu and ExportButton JSX components from the useExport hook, so as the useExport hook is called at every render, these also are changing _(function signatures)_ and rerendered. The jumping is because of the difference in time taken to render the icons used inside the 2 above-mentioned functions. I think converting the hook to a component should fix it, what are ur thoughts?
https://github.com/coronasafe/care_fe/issues/4353#issuecomment-1357596582
Shared a comment on a pull request in coronasafe/care_fe on December 18, 2022 at 2:16:12 PM
Looks great, @nihal467 your thoughts?
https://github.com/coronasafe/care_fe/pull/4028#issuecomment-1356808692
Shared a comment on a pull request in coronasafe/care_fe on December 18, 2022 at 7:31:10 AM
@nihal467 merging this pr as it is a p1 issue, following this issue in a new pr
https://github.com/coronasafe/care_fe/pull/4294#issuecomment-1356721739
Shared a comment on a pull request in coronasafe/care_fe on December 16, 2022 at 1:06:31 PM
@nihal467 this pr was already discussed in yesterday's EOD I guess, wasn't it already approved @rithviknishad?
https://github.com/coronasafe/care_fe/pull/4310#issuecomment-1354739652
Shared a comment on a pull request in coronasafe/care_fe on December 16, 2022 at 1:03:38 PM
@nihal467 @cp-Coder there is a minor problem, once the state is selected we can't select 'choose state' again, and the same with the district, local body, and ward too. I am anyways merging this pr because those are mandatory fields.
https://github.com/coronasafe/care_fe/pull/4315#issuecomment-1354736401
Shared a comment on a pull request in coronasafe/care_fe on December 16, 2022 at 12:53:09 PM
checked it in ubuntu -> chrome -> LibreOffice calc, works fine LGTM cc: @nihal467
https://github.com/coronasafe/care_fe/pull/3980#issuecomment-1354722240
Shared a comment on a pull request in coronasafe/care_fe on December 16, 2022 at 12:32:45 PM
@skks1212 can you check this and clear it out as soon as possible
https://github.com/coronasafe/care_fe/pull/4294#issuecomment-1354701086
Shared a comment on a pull request in coronasafe/care_fe on December 13, 2022 at 11:49:29 AM
@Pragati1610 what's the status of this one
https://github.com/coronasafe/care_fe/pull/3307#issuecomment-1348351214
Shared a comment on a pull request in coronasafe/care_fe on December 13, 2022 at 11:24:29 AM
@nihal467 @skks1212 I agree, may be on top of it we could have some kind of isValidPhoneNumber regex or function to validate it :thinking:
https://github.com/coronasafe/care_fe/pull/4294#issuecomment-1348269973
Shared a comment on a pull request in coronasafe/teleicu_middleware on December 9, 2022 at 2:21:53 AM
> @khavinshankar We need a 200+ Response when `within_last_minute` is true, and a 400+ Response when it's false. This is to allow monitoring the status of the CNS @gigincg done, if the request is within the last minute the response is 200 Ok, else it is 412 Precondition Failed
https://github.com/coronasafe/teleicu_middleware/pull/62#issuecomment-1343754390
Shared a comment on an issue in coronasafe/care_fe on December 7, 2022 at 2:28:15 PM
@nihal467 downgrading it to a P2 issue as this doesn't break anything, It will be ready by this week
https://github.com/coronasafe/care_fe/issues/4115#issuecomment-1341047922
Shared a comment on an issue in coronasafe/care_fe on December 7, 2022 at 4:19:31 AM
@cp-coder what's the status of this issue? On Wed, 7 Dec 2022, 09:46 github-actions[bot], ***@***.***> wrote: > Hi, @gigincg <https://github.com/gigincg>, @nihal467 > <https://github.com/nihal467>, @khavinshankar > <https://github.com/khavinshankar>, @mathew-alex > <https://github.com/mathew-alex>, @aparnacoronasafe > <https://github.com/aparnacoronasafe>, This issue has been automatically > marked as stale because it has not had any recent activity. > > — > Reply to this email directly, view it on GitHub > <https://github.com/coronasafe/care_fe/issues/4096#issuecomment-1340351717>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AHDIM7AAR7YQJH3PTU2USPLWMAFS5ANCNFSM6AAAAAASHUNQA4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >
https://github.com/coronasafe/care_fe/issues/4096#issuecomment-1340353443
Shared a comment on a pull request in coronasafe/care_fe on December 6, 2022 at 8:37:55 AM
@Ashesh3 can you re-review this one
https://github.com/coronasafe/care_fe/pull/4124#issuecomment-1338967343
Shared a comment on a pull request in coronasafe/care_fe on December 6, 2022 at 8:30:18 AM
- [ ] Add max and min props in DateInputV2 to set limits or constraints for date selection
https://github.com/coronasafe/care_fe/pull/4094#issuecomment-1338958333
Shared a comment on an issue in coronasafe/care_fe on December 6, 2022 at 7:09:14 AM
@cp-Coder what's the status of this issue cc: @nihal467
https://github.com/coronasafe/care_fe/issues/3983#issuecomment-1338884733
Shared a comment on an issue in coronasafe/care_fe on December 5, 2022 at 11:32:37 AM
This was happening specifically when we change devices i.e., from IOS to other or vice versa, when we switch devices inside inspector the order of the hooks were changed which caused this issue ![image](https://user-images.githubusercontent.com/29787772/205627002-3f0c3b88-c10e-416c-8ace-f7dbfdab3d5d.png) This is unlikely to occur in prod, so closing this issue
https://github.com/coronasafe/care_fe/issues/3826#issuecomment-1337181017
Shared a comment on a pull request in coronasafe/care_fe on December 4, 2022 at 5:00:19 AM
> > @Ashesh3 what is the update on this PR > > Hey, @khavinshankar mentioned you in the review above and requested your take on what should be done here for inputs. If you could respond there and let me know, i can proceed accordingly. https://github.com/coronasafe/care_fe/pull/4028#discussion_r1031090235
https://github.com/coronasafe/care_fe/pull/4028#issuecomment-1336322378
Shared a comment on a pull request in coronasafe/care_fe on December 3, 2022 at 4:14:32 PM
closing this
https://github.com/coronasafe/care_fe/pull/4199#issuecomment-1336191253
Shared a comment on a pull request in coronasafe/care_fe on December 1, 2022 at 3:36:47 AM
@developedBySJ can you re-review this
https://github.com/coronasafe/care_fe/pull/4109#issuecomment-1333118279
Shared a comment on a pull request in coronasafe/care_fe on November 30, 2022 at 11:20:59 AM
@rithviknishad can u re-review this
https://github.com/coronasafe/care_fe/pull/4145#issuecomment-1332000062
Shared a comment on a pull request in coronasafe/care_fe on November 28, 2022 at 2:02:27 AM
![image](https://user-images.githubusercontent.com/29787772/204175970-f5bb164b-986a-4938-ba71-dc5d0cadf891.png)
https://github.com/coronasafe/care_fe/pull/4130#issuecomment-1328429909
Shared a comment on a pull request in coronasafe/care_fe on November 27, 2022 at 7:46:00 AM
@cp-Coder can you also handle issue #4126 in this pr?
https://github.com/coronasafe/care_fe/pull/4063#issuecomment-1328189536
Shared a comment on an issue in coronasafe/care_fe on November 27, 2022 at 7:45:38 AM
Todo - [ ] age field is misaligned - [ ] y-axis spacing is a bit much - [ ] page is not responsive
https://github.com/coronasafe/care_fe/issues/4126#issuecomment-1328189497
Shared a comment on an issue in coronasafe/care_fe on November 23, 2022 at 7:09:15 AM
Fixed in https://github.com/coronasafe/care_fe/pull/4016
https://github.com/coronasafe/care_fe/issues/3879#issuecomment-1324635265
Shared a comment on a pull request in coronasafe/care_fe on November 21, 2022 at 1:43:49 PM
@Pragati1610 @rithviknishad the deploy seems to be failing ![image](https://user-images.githubusercontent.com/29787772/203070246-d40115ad-81d0-4fc5-a087-fc08a65996a5.png)
https://github.com/coronasafe/care_fe/pull/3307#issuecomment-1322086848
Shared a comment on an issue in coronasafe/care_fe on November 17, 2022 at 7:14:53 AM
@Ashesh3 @nihal467 this issue is resolved and can be closed
https://github.com/coronasafe/care_fe/issues/2366#issuecomment-1318191653
Shared a comment on a pull request in coronasafe/care_fe on November 16, 2022 at 1:40:51 PM
@nihal467 can you retest this pr?
https://github.com/coronasafe/care_fe/pull/4061#issuecomment-1317042015
Shared a comment on an issue in coronasafe/care_fe on November 16, 2022 at 1:40:12 PM
@nihal467 @Pranshu1902 It would be a good idea to also block it in the backend
https://github.com/coronasafe/care_fe/issues/4060#issuecomment-1317041099
Shared a comment on a pull request in coronasafe/care_fe on November 11, 2022 at 12:54:13 PM
> @khavinshankar the button is not working @nihal467 can you try it in incognito, it seems to be working fine
https://github.com/coronasafe/care_fe/pull/3817#issuecomment-1311665892
Shared a comment on a pull request in coronasafe/care_fe on November 11, 2022 at 12:03:13 PM
@rithviknishad @nihal467 There seem to be some side effects: **Steps:** _in facilities page_ 1. Search something in the facility search 2. Remove the search term 3. Now try to change page 4. *Problem: * the page seems to reset to 1 also test the same in others too @nihal467 _lets hold this on for next production release_
https://github.com/coronasafe/care_fe/pull/4017#issuecomment-1311613328
Shared a comment on an issue in coronasafe/care_fe on November 11, 2022 at 11:09:34 AM
@Ritesh-Aggarwal initially we had results from the backend that was not an exact match of the search term but now it has been improved. I think this issue can be closed, but if there is any improvement you can do to the filter then feel free to try it out.
https://github.com/coronasafe/care_fe/issues/3477#issuecomment-1311558874
Shared a comment on a pull request in coronasafe/care_fe on November 10, 2022 at 11:50:04 AM
Putting this pr on hold till #4017 is tested
https://github.com/coronasafe/care_fe/pull/3965#issuecomment-1310168816
Shared a comment on a pull request in coronasafe/care_fe on November 10, 2022 at 11:36:05 AM
@cp-Coder In assets, changing the page and filtering doesn't reset it to page 1. Test other pages too.
https://github.com/coronasafe/care_fe/pull/3965#issuecomment-1310151489
Shared a comment on a pull request in coronasafe/care_fe on November 10, 2022 at 8:34:33 AM
@nihal467 the icon on the top left is used to get the current location ![image](https://user-images.githubusercontent.com/29787772/201040906-ec9e0df3-2b63-49c5-af00-b3c3a86473ce.png)
https://github.com/coronasafe/care_fe/pull/3817#issuecomment-1309943105
Shared a comment on a pull request in coronasafe/care_fe on November 10, 2022 at 8:04:23 AM
Closing this pr, ref: #4017
https://github.com/coronasafe/care_fe/pull/4004#issuecomment-1309912016
Shared a comment on a pull request in coronasafe/care_fe on November 9, 2022 at 11:08:55 AM
@siddnikh @nihal467 we still have the problem of validation going wrong for the deleted users, i.e., when we delete a user, we are soft deleting them which is not accounted here, this has to be changed in the backend, the frontend integration is fine, so merging this
https://github.com/coronasafe/care_fe/pull/3700#issuecomment-1308588357
Shared a comment on a pull request in coronasafe/care_fe on November 9, 2022 at 10:54:13 AM
@nihal467 can you retest this pr
https://github.com/coronasafe/care_fe/pull/3897#issuecomment-1308569404
Shared a comment on a pull request in coronasafe/care_fe on November 9, 2022 at 10:46:37 AM
> @khavinshankar @nihal467 @patelaryan7751 how about showing the associated facility without "@" prefix but in `text-gray-700` instead of having "@ facility name"? that's a nice idea
https://github.com/coronasafe/care_fe/pull/3897#issuecomment-1308560471
Shared a comment on an issue in coronasafe/care_fe on November 8, 2022 at 5:31:25 AM
@nihal467 merging #3882 should fix it, closing this issue, feel free to reopen it if the problem persists
https://github.com/coronasafe/care_fe/issues/3973#issuecomment-1306659395
Shared a comment on an issue in coronasafe/care_fe on November 8, 2022 at 5:28:16 AM
fixed in #3906
https://github.com/coronasafe/care_fe/issues/3904#issuecomment-1306657378
Shared a comment on an issue in coronasafe/care_fe on November 7, 2022 at 4:42:25 AM
@nihal467 does this problem still persist?
https://github.com/coronasafe/care_fe/issues/3812#issuecomment-1305072703
Shared a comment on a pull request in coronasafe/care_fe on November 6, 2022 at 10:23:38 AM
> @khavinshankar the issue is still present. However, it's solved in #3977 ![image](https://user-images.githubusercontent.com/25143503/200164517-8b5cc074-b22c-4bff-bf4d-48d62a0fa414.png) @rithviknishad the issue seems to be present in the pr that you mentioned https://deploy-preview-3977--care-net.netlify.app/facility/01810c32-ec26-494a-9e65-40e5547a7746/patient/9c6a4951-916e-439b-b41a-853b6980fefa/consultation/a8003ba0-9c0a-4d27-95b2-d3bd3139652f/update
https://github.com/coronasafe/care_fe/pull/3979#issuecomment-1304767643
Shared a comment on an issue in coronasafe/10bedicu on November 2, 2022 at 1:11:27 PM
@aparnacoronasafe this issue has been resolved
https://github.com/coronasafe/10bedicu/issues/52#issuecomment-1300385790
Shared a comment on an issue in coronasafe/care_fe on November 2, 2022 at 6:36:42 AM
done, @comradekingu closing this issue now, feel free to open a new issue
https://github.com/coronasafe/care_fe/issues/3377#issuecomment-1299648649
Shared a comment on an issue in coronasafe/care_fe on November 2, 2022 at 6:35:09 AM
Fixed
https://github.com/coronasafe/care_fe/issues/3860#issuecomment-1299647330
Shared a comment on an issue in coronasafe/care_fe on November 2, 2022 at 5:21:47 AM
@rabilrbl can u give a link of the pr or action where this is happening
https://github.com/coronasafe/care_fe/issues/3905#issuecomment-1299589232
Shared a comment on a pull request in coronasafe/care_fe on November 2, 2022 at 2:35:59 AM
@nihal467 can you try this in the incognito tab
https://github.com/coronasafe/care_fe/pull/3906#issuecomment-1299482109
Shared a comment on an issue in coronasafe/care_fe on November 2, 2022 at 1:52:11 AM
@rabilrbl is this happening for forks?
https://github.com/coronasafe/care_fe/issues/3905#issuecomment-1299447627
Shared a comment on a pull request in coronasafe/care_fe on November 1, 2022 at 10:03:55 AM
Fixes #3904
https://github.com/coronasafe/care_fe/pull/3906#issuecomment-1298298008
Shared a comment on a pull request in coronasafe/care_fe on November 1, 2022 at 8:20:06 AM
@nihal467 yes, it was done by @arpancodes long back, i'm not sure even if this is relevant anymore, we already investigation, so not sure if we need procedure
https://github.com/coronasafe/care_fe/pull/3356#issuecomment-1298199891
Shared a comment on an issue in coronasafe/10bedicu on November 1, 2022 at 1:47:45 AM
@aparnacoronasafe In Manipur's sheet, we have 7 extra columns, is it possible to add those extra columns in other sheets too?
https://github.com/coronasafe/10bedicu/issues/52#issuecomment-1297906651
Shared a comment on a pull request in coronasafe/care_dashboard on October 29, 2022 at 3:19:28 PM
Already merged
https://github.com/coronasafe/care_dashboard/pull/55#issuecomment-1295868770
Shared a comment on an issue in coronasafe/care_fe on October 29, 2022 at 2:06:18 PM
@nihal467 no, this should be an easy fix at the backend
https://github.com/coronasafe/care_fe/issues/3860#issuecomment-1295846792
Shared a comment on a pull request in coronasafe/care_fe on October 26, 2022 at 1:40:01 PM
> ![image](https://user-images.githubusercontent.com/57055998/198035146-5654b79c-742a-4492-93b6-4e12dd2aa39c.png) > > * [ ] the search bar is covering the whole map, now, unable to see the map @nihal467 This is working fine in the local, this issue is caused due to permission error, @mathew-alex can you please check this out ![image](https://user-images.githubusercontent.com/29787772/198041363-117ce40b-f154-44fd-9487-6db1d5b8dd56.png)
https://github.com/coronasafe/care_fe/pull/3817#issuecomment-1292065298
Shared a comment on a pull request in coronasafe/care_fe on October 26, 2022 at 1:21:15 PM
@rithviknishad can you check out the vercel error
https://github.com/coronasafe/care_fe/pull/3801#issuecomment-1292026452
Shared a comment on a pull request in coronasafe/care_fe on October 26, 2022 at 9:20:09 AM
@nihal467 > @khavinshankar ![image](https://user-images.githubusercontent.com/57055998/197983701-bcfbf1c3-4544-4592-a118-6bcf2cdb2606.png) > > * [x] the push score is so close to the buttons, can anything be done to that in the mobile view That is already fixed, try hard refresh or try it in incognito tab > ![image](https://user-images.githubusercontent.com/57055998/197984358-9234f8aa-5083-4b77-8fbe-3769817ac33e.png) > > * [ ] in the summary page, how to view this push score, as of now, cant find anything saying about push score let's make this a new issue, so that this can be pushed out > * [x] merge the latest development branch done
https://github.com/coronasafe/care_fe/pull/3796#issuecomment-1291747999
Shared a comment on a pull request in coronasafe/care_fe on October 26, 2022 at 8:37:40 AM
hey @Ashesh3, just wanted to check, this is the only code change, right? ![image](https://user-images.githubusercontent.com/29787772/197977328-69071400-e652-4053-b4f8-f8bebb20aded.png)
https://github.com/coronasafe/care_fe/pull/3824#issuecomment-1291692726
Shared a comment on an issue in coronasafe/care_fe on October 26, 2022 at 3:29:47 AM
Closing this issue as this seems to be working fine, feel free to reopen or create a new issue if the same exists
https://github.com/coronasafe/care_fe/issues/3411#issuecomment-1291448916
Shared a comment on an issue in coronasafe/care_fe on October 26, 2022 at 3:14:29 AM
@nihal467 This issue is only happening when the screen size is altered manually
https://github.com/coronasafe/care_fe/issues/3826#issuecomment-1291439626
Shared a comment on an issue in coronasafe/care on October 24, 2022 at 8:56:44 AM
@cp-Coder can you push the pr for this issue by EOD, it's an urgent one cc: @nihal467
https://github.com/coronasafe/care/issues/1075#issuecomment-1288679758
Shared a comment on a pull request in coronasafe/care_fe on October 24, 2022 at 8:35:49 AM
@nihal467 In the above-mentioned issues, the first will be fixed in the pr for https://github.com/coronasafe/care/issues/1075, and the second one should already be fixed
https://github.com/coronasafe/care_fe/pull/3815#issuecomment-1288641741
Shared a comment on an issue in coronasafe/care_fe on October 24, 2022 at 1:36:05 AM
@nihal467 this has been a recent change in the backend regarding https://github.com/coronasafe/care_fe/issues/1255#issuecomment-1256315589. @aparnacoronasafe @gigincg So should I have to make the Review After optional?
https://github.com/coronasafe/care_fe/issues/3814#issuecomment-1288289992
Shared a comment on an issue in coronasafe/care_fe on October 21, 2022 at 4:50:24 AM
Resolved in #3785
https://github.com/coronasafe/care_fe/issues/3770#issuecomment-1286456853
Shared a comment on an issue in coronasafe/care_fe on October 21, 2022 at 4:49:50 AM
Fixed in #3777
https://github.com/coronasafe/care_fe/issues/3776#issuecomment-1286456503
Shared a comment on a pull request in coronasafe/care_fe on October 21, 2022 at 4:15:48 AM
@patelaryan7751 just some minor refactors here and there
https://github.com/coronasafe/care_fe/pull/3586#issuecomment-1286436398
Shared a comment on an issue in coronasafe/leaderboard on October 17, 2022 at 3:00:00 AM
Fixed in https://github.com/coronasafe/leaderboard/pull/94
https://github.com/coronasafe/leaderboard/issues/93#issuecomment-1280208670
Shared a comment on a pull request in coronasafe/leaderboard on October 17, 2022 at 2:53:20 AM
@Pranshu1902 merge conflicts
https://github.com/coronasafe/leaderboard/pull/86#issuecomment-1280205720
Shared a comment on a pull request in coronasafe/care_fe on October 16, 2022 at 7:24:30 AM
merging this pr for now, if there is any follow-up that involves code change, feel free to create a new pr
https://github.com/coronasafe/care_fe/pull/3372#issuecomment-1279910989
Shared a comment on a pull request in coronasafe/care_fe on October 12, 2022 at 9:41:06 AM
@Ritesh-Aggarwal can you double-check it once again, when I go to the pressure sore tab, it scrolls to the top, also when I go to a different tab and go back to updates, it scrolls back to the top, also check other tabs too
https://github.com/coronasafe/care_fe/pull/3731#issuecomment-1275881601
Shared a comment on a pull request in coronasafe/care_fe on October 12, 2022 at 7:09:07 AM
@Pranshu1902, I think reducing the icon size might help, and I also think the color is off
https://github.com/coronasafe/care_fe/pull/3419#issuecomment-1275692902
Shared a comment on a pull request in coronasafe/care_dashboard on October 12, 2022 at 5:58:53 AM
@Ritesh-Aggarwal is this ready to be reviewed?
https://github.com/coronasafe/care_dashboard/pull/37#issuecomment-1275631198
Shared a comment on an issue in coronasafe/care_fe on October 12, 2022 at 5:56:51 AM
@rithviknishad do you need any help with this?
https://github.com/coronasafe/care_fe/issues/3742#issuecomment-1275629422
Shared a comment on a pull request in coronasafe/leaderboard on October 11, 2022 at 5:04:27 AM
@Pranshu1902 can you just test if along with the shadow, the transition also looks good?
https://github.com/coronasafe/leaderboard/pull/92#issuecomment-1274092661
Shared a comment on a pull request in coronasafe/leaderboard on October 11, 2022 at 5:03:00 AM
@Pranshu1902 check out the merge conflict
https://github.com/coronasafe/leaderboard/pull/83#issuecomment-1274091924
Shared a comment on an issue in coronasafe/leaderboard on October 11, 2022 at 2:44:33 AM
@bodhish It seems there is no REST API support for GitHub discussions (https://github.com/community/community/discussions/4327), should we use GraphQl?
https://github.com/coronasafe/leaderboard/issues/68#issuecomment-1274017238
Shared a comment on a pull request in coronasafe/care_fe on August 19, 2022 at 2:03:30 AM
@developedBySJ can you please rereview this one?
https://github.com/coronasafe/care_fe/pull/3228#issuecomment-1220156663
Shared a comment on a pull request in coronasafe/care_fe on August 19, 2022 at 1:56:39 AM
@developedBySJ can you please rereview this one?
https://github.com/coronasafe/care_fe/pull/3288#issuecomment-1220153616
Shared a comment on an issue in coronasafe/care_fe on August 16, 2022 at 6:22:08 AM
@patelaryan7751 It seems to be working at my end, maybe can you give the link of the patient for whom it was not working at your end, I'll check it out ![image](https://user-images.githubusercontent.com/29787772/184810638-c51fd866-4323-44e0-8657-d4b325321a09.png)
https://github.com/coronasafe/care_fe/issues/3411#issuecomment-1216196382
Shared a comment on an issue in coronasafe/care_fe on August 16, 2022 at 2:22:17 AM
@aparnacoronasafe @ishanExtreme Instead of adding a new field for `Admit Date` in the `Advanced Filters` like ![Screenshot from 2022-06-29 20-59-54](https://user-images.githubusercontent.com/39593226/176476944-1326b767-0b4f-4516-888b-337069a2094a.png) why don't we just use the existing `Admit Date` field, we can set both `from` and `to` dates to the same date to achieve the behavior we want ![image](https://user-images.githubusercontent.com/29787772/184655560-c098dc4a-b730-4a11-a5c2-3a335b215998.png)
https://github.com/coronasafe/care_fe/issues/1789#issuecomment-1216069478
Shared a comment on a pull request in coronasafe/care_fe on August 10, 2022 at 1:45:38 PM
@developedBySJ can you please rereview this?
https://github.com/coronasafe/care_fe/pull/3205#issuecomment-1210697638
Shared a comment on a pull request in coronasafe/care_fe on July 31, 2022 at 2:13:19 PM
@nihal467 there is not much to test in this pr, it is more of refactoring going on, it is ready to be merged
https://github.com/coronasafe/care_fe/pull/2538#issuecomment-1200433527
Shared a comment on a pull request in coronasafe/care_fe on July 31, 2022 at 2:10:49 PM
@nihal467 this won't work in the netlify deploy because the gmap api key permissions are not given for netlify sites, either we can merge this into staging (it should work in staging) and test it or we can ask mathew to add permissions to the api key to allow netlify
https://github.com/coronasafe/care_fe/pull/2921#issuecomment-1200433078
Shared a comment on a pull request in coronasafe/care_fe on July 31, 2022 at 1:50:35 PM
@nihal467 This pr was aimed at fixing eslint errors and warnings but now lot has changed and most of the eslint errors are fixed, so I think this pr is not relevant anymore There are few errors here and there, those can be fixed as we make changes, same can be done for the warnings, so I'll close this pr, feel free to open this if necessary.
https://github.com/coronasafe/care_fe/pull/2095#issuecomment-1200429407
Shared a comment on a pull request in coronasafe/care on July 26, 2022 at 12:54:29 PM
continued in #947
https://github.com/coronasafe/care/pull/864#issuecomment-1195444656
Shared a comment on a pull request in coronasafe/care on July 26, 2022 at 9:01:44 AM
This pr adds features to use the classification of diseases from ICD11 (https://icd.who.int/) **_Refer: https://github.com/coronasafe/care_fe/issues/2016_** _context: Initially, for the same thing proxying was suggested _(care fe -> be -> icd.who.int)_ [#864] but Bodhi suggested to store the diseases directly in care db because of the reliability issues_ 4 endpoints are added: ![image](https://user-images.githubusercontent.com/29787772/180965655-750bb5c1-c654-4ad8-8185-e336483b9fd7.png) **GET /icd**: for searching the diseases using label **GET /icd/{id}**: for get a specific disease by id **POST /icd**: for adding new disease or diseases (if needed) **GET /icd/scrape** _(only can be accessed by admin user)_: for triggering celery task for scraping icd website and adding those diseases to db
https://github.com/coronasafe/care/pull/947#issuecomment-1195207226
Shared a comment on a pull request in coronasafe/care_fe on July 21, 2022 at 5:20:06 AM
@nihal467 @patelaryan7751 is this pr complete? Aren't you making this icons as pictures, right?
https://github.com/coronasafe/care_fe/pull/3117#issuecomment-1191050657
Shared a comment on a pull request in coronasafe/care_fe on July 21, 2022 at 5:01:50 AM
@patelaryan7751 making the filename mandatory can reduce the user experience, so can you make it similar to audio file, giving some template name? @nihal467 what do you think?
https://github.com/coronasafe/care_fe/pull/3007#issuecomment-1191041026
Shared a comment on a pull request in coronasafe/care_fe on July 15, 2022 at 8:26:37 AM
![image](https://user-images.githubusercontent.com/29787772/179184247-87438b5f-e295-4dc6-8b21-f3ce9a8967ba.png) @siddnikh the selected value is not showing
https://github.com/coronasafe/care_fe/pull/2808#issuecomment-1185305997
Shared a comment on a pull request in coronasafe/10bedicu on July 12, 2022 at 12:30:05 PM
@kunatastic its seems we have few responsiveness issues when we resize the screen, ![image](https://user-images.githubusercontent.com/29787772/178488094-ccb6aa0a-60ac-42f2-a68a-396cac2a7e57.png)
https://github.com/coronasafe/10bedicu/pull/50#issuecomment-1181701413
Shared a comment on a pull request in coronasafe/care_fe on July 12, 2022 at 6:45:02 AM
@Pranshu1902 please do remove the button in the update form ![image](https://user-images.githubusercontent.com/29787772/178425653-45747e2d-3aed-4789-88c3-ac578ef08e70.png)
https://github.com/coronasafe/care_fe/pull/3054#issuecomment-1181379640
Shared a comment on a pull request in coronasafe/care_fe on July 9, 2022 at 10:19:11 AM
@rithviknishad the new component looks awesome, I'll refactor it, thanks
https://github.com/coronasafe/care_fe/pull/2947#issuecomment-1179518739
Shared a comment on a pull request in coronasafe/care_fe on July 9, 2022 at 6:57:29 AM
@nihal467 can you please give a patient's link where it is still going wrong
https://github.com/coronasafe/care_fe/pull/3064#issuecomment-1179492300
Shared a comment on a pull request in coronasafe/care_fe on July 6, 2022 at 12:29:18 PM
@kunatastic please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2409#issuecomment-1176162722
Shared a comment on a pull request in coronasafe/care_fe on July 6, 2022 at 11:52:06 AM
@rithviknishad @gigincg is it good to be merged?
https://github.com/coronasafe/care_fe/pull/2286#issuecomment-1176127542
Shared a comment on a pull request in coronasafe/care_fe on July 6, 2022 at 10:08:53 AM
@patelaryan7751 make the name field optional or have a default value for the name field like suggested by Bodhi in weekly meet
https://github.com/coronasafe/care_fe/pull/2957#issuecomment-1176038044
Shared a comment on a pull request in coronasafe/care_fe on July 6, 2022 at 9:49:29 AM
![image](https://user-images.githubusercontent.com/29787772/177522613-a29a861f-adeb-4ada-8143-340ef7ed4577.png) ![image](https://user-images.githubusercontent.com/29787772/177522933-0589289f-55b2-4e39-99f0-79e93d3fd26e.png) @Pranshu1902 the UI seems to be off
https://github.com/coronasafe/care_fe/pull/2906#issuecomment-1176019433
Shared a comment on a pull request in coronasafe/care_fe on July 6, 2022 at 9:13:40 AM
@kunatastic there are some minor changes, can you please address them
https://github.com/coronasafe/care_fe/pull/2409#issuecomment-1175982310
Shared a comment on a pull request in coronasafe/care_fe on July 6, 2022 at 9:06:41 AM
@cp-Coder can you check it once please
https://github.com/coronasafe/care_fe/pull/2407#issuecomment-1175975119
Shared a comment on a pull request in coronasafe/care_fe on July 4, 2022 at 9:50:46 AM
@patelaryan7751 can you please work on the requested changes and resolve the merge conflict
https://github.com/coronasafe/care_fe/pull/2768#issuecomment-1173605227
Shared a comment on a pull request in coronasafe/care on July 4, 2022 at 3:46:35 AM
Yes, we can access this API from front-end but every time we want to access any endpoint, we have to get the bearer token first (authentication is needed). If it is done in the front-end, we have to do the authentication for every client, so thought of going with backend. @vigneshhari So what are your thoughts Vignesh, should I move this to frontend?
https://github.com/coronasafe/care/pull/864#issuecomment-1173306826
Shared a comment on a pull request in coronasafe/care_fe on June 30, 2022 at 1:30:12 PM
@Pranshu1902 please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2906#issuecomment-1171222959
Shared a comment on a pull request in coronasafe/care_fe on June 30, 2022 at 1:21:54 PM
@Pranshu1902 please do work on the merge confict
https://github.com/coronasafe/care_fe/pull/2912#issuecomment-1171213745
Shared a comment on a pull request in coronasafe/care_fe on June 30, 2022 at 1:20:01 PM
@GokulramGHV please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2901#issuecomment-1171211655
Shared a comment on a pull request in coronasafe/leaderboard on June 28, 2022 at 11:23:02 AM
The UI: ![image](https://user-images.githubusercontent.com/29787772/176166661-1105d514-e0d1-4fa3-998d-969e18fea76b.png)
https://github.com/coronasafe/leaderboard/pull/60#issuecomment-1168593983
Shared a comment on a pull request in coronasafe/leaderboard on June 28, 2022 at 11:23:02 AM
The UI: ![image](https://user-images.githubusercontent.com/29787772/176166661-1105d514-e0d1-4fa3-998d-969e18fea76b.png)
https://github.com/coronasafe/leaderboard/pull/60#issuecomment-1168593983
Shared a comment on a pull request in coronasafe/care_fe on June 23, 2022 at 9:33:49 AM
@skks1212 please do work on the merge conflicts
https://github.com/coronasafe/care_fe/pull/2699#issuecomment-1164178367
Shared a comment on a pull request in coronasafe/care_fe on June 23, 2022 at 9:33:49 AM
@skks1212 please do work on the merge conflicts
https://github.com/coronasafe/care_fe/pull/2699#issuecomment-1164178367
Shared a comment on a pull request in coronasafe/care_fe on June 23, 2022 at 9:08:56 AM
@patelaryan7751 just a suggestion, usually in care we have all of the action buttons to the right especially in forms, so I think it would be better if the button is right aligned instead of the center, 🤔 what do you think?
https://github.com/coronasafe/care_fe/pull/2689#issuecomment-1164153665
Shared a comment on a pull request in coronasafe/care_fe on June 23, 2022 at 8:57:30 AM
@Ashesh3 sorry about that, this issue was reported and wanted to be fixed urgent, so when I searched the issues, there was no issue regarding this error, so I kinda went a head and made a pr without searching if there was any pr related to this. 😅 It's my bad, just to be more careful for here on, I suggest creating an issue and assign it to yourself and move a head with pr. sorry again Ashesh.
https://github.com/coronasafe/care_fe/pull/2715#issuecomment-1164141743
Shared a comment on a pull request in coronasafe/care_fe on June 23, 2022 at 8:11:40 AM
@Ashesh3 This issue has already been fixed in https://github.com/coronasafe/care_fe/pull/2729.
https://github.com/coronasafe/care_fe/pull/2715#issuecomment-1164095076
Shared a comment on a pull request in coronasafe/care_fe on June 17, 2022 at 12:09:43 PM
@nihal467 can you test this one out
https://github.com/coronasafe/care_fe/pull/2690#issuecomment-1158808155
Shared a comment on a pull request in coronasafe/care_fe on June 17, 2022 at 8:13:00 AM
closing this pr due to the merging issues, follow up pr #2730
https://github.com/coronasafe/care_fe/pull/2491#issuecomment-1158617466
Shared a comment on a pull request in coronasafe/care_fe on June 11, 2022 at 12:56:26 PM
Closing this pr because of wrong merge, follow up with #2681
https://github.com/coronasafe/care_fe/pull/2428#issuecomment-1152923349
Shared a comment on a pull request in coronasafe/care_fe on June 10, 2022 at 1:07:37 PM
@skks1212 can you please check this out, ![image](https://user-images.githubusercontent.com/29787772/173070820-b9a817f1-3ba6-4f76-9321-33601ee42c83.png) the build is failing because of this
https://github.com/coronasafe/care_fe/pull/2563#issuecomment-1152341996
Shared a comment on a pull request in coronasafe/care_fe on June 10, 2022 at 9:11:25 AM
@skks1212 please do check out the deploy issue and also do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2563#issuecomment-1152150234
Shared a comment on a pull request in coronasafe/care_fe on June 10, 2022 at 5:57:26 AM
@skks1212 please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2563#issuecomment-1151978231
Shared a comment on an issue in coronasafe/leaderboard on June 9, 2022 at 2:19:57 AM
@rithviknishad got it 👍 thanks for the headsup, I'll just push additional changes after that pr is merged
https://github.com/coronasafe/leaderboard/issues/56#issuecomment-1150598291
Shared a comment on a pull request in coronasafe/care_fe on June 9, 2022 at 1:59:35 AM
@gigincg initially I thought this could help user experience but now I feel that floating icon is just an excess (like anyways we can access the notifications in one click using the sidebar). So come to think of it now, it doesn't make much sense. So I think we can close this pr and issue.
https://github.com/coronasafe/care_fe/pull/2412#issuecomment-1150588270
Shared a comment on a pull request in coronasafe/care_fe on June 6, 2022 at 1:06:37 PM
@rithviknishad please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2470#issuecomment-1147426268
Shared a comment on a pull request in coronasafe/care_fe on June 6, 2022 at 11:01:35 AM
@nihal467 the floating icon corresponds to notifications and has no relation to notice board, can you please re-test this pr
https://github.com/coronasafe/care_fe/pull/2412#issuecomment-1147324158
Shared a comment on a pull request in coronasafe/care_fe on June 6, 2022 at 6:13:49 AM
fixed the padding issue ![image](https://user-images.githubusercontent.com/29787772/172105567-96d9f2d4-2261-4ade-8838-1665ccb522c2.png)
https://github.com/coronasafe/care_fe/pull/2534#issuecomment-1147085906
Shared a comment on a pull request in coronasafe/care_fe on June 3, 2022 at 4:39:10 AM
@kunatastic please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2409#issuecomment-1145577692
Shared a comment on a pull request in coronasafe/care_fe on June 3, 2022 at 4:37:53 AM
@Ashesh3 please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2442#issuecomment-1145577250
Shared a comment on a pull request in coronasafe/care_fe on June 3, 2022 at 4:20:17 AM
@Ritesh-Aggarwal please do work on the merge conflicts
https://github.com/coronasafe/care_fe/pull/2480#issuecomment-1145570669
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2022 at 11:27:04 AM
@rabilrbl please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2576#issuecomment-1144754113
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2022 at 11:19:34 AM
@patelaryan7751 please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2558#issuecomment-1144747230
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2022 at 11:15:36 AM
@patelaryan7751 please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2528#issuecomment-1144743497
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2022 at 9:19:29 AM
@rabilrbl please do work on the merge conflicts
https://github.com/coronasafe/care_fe/pull/2567#issuecomment-1144640425
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2022 at 9:15:40 AM
@rabilrbl please do work on the merge conflict
https://github.com/coronasafe/care_fe/pull/2570#issuecomment-1144636941
Shared a comment on an issue in coronasafe/care_fe on June 2, 2022 at 8:38:27 AM
duplicate issue, follow issue #2515 for further information
https://github.com/coronasafe/care_fe/issues/2631#issuecomment-1144602718
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2022 at 8:27:25 AM
@ishanExtreme is this pr good to be merged or is there anything pending that is to be done through this pr? I see a pending task related to Location Management, so if my understanding is correct that will be handled through a different pr right?
https://github.com/coronasafe/care_fe/pull/2571#issuecomment-1144592316
Shared a comment on a pull request in coronasafe/care_fe on June 1, 2022 at 12:53:34 PM
- [x] Hid review alert when the patient is discharged - [x] Hid review alert when a daily round is created or when update is made after review time - [x] In daily rounds form, added a hint to show the next expected review time ![image](https://user-images.githubusercontent.com/29787772/171404644-52b17c31-8f78-4971-9003-0d95d70508a6.png) ![image](https://user-images.githubusercontent.com/29787772/171404899-bbcc2aee-d4e6-45fe-a2e6-1551b06ad3a7.png) ![image](https://user-images.githubusercontent.com/29787772/171404557-dc864a5c-7fcb-4c58-b4a1-04349bdfccec.png) _**Considerations:**_ - _Because we are storing absolute time in the backend and here in the frontend we are using relative time for `review_time` without any reference, it is not possible to set previous review time value in the form, so I went with the hint that notifies the user about the previous review time_
https://github.com/coronasafe/care_fe/pull/2600#issuecomment-1143572941
Shared a comment on an issue in coronasafe/care_fe on June 1, 2022 at 6:28:08 AM
duplicate issue follow issue #2609 for further information
https://github.com/coronasafe/care_fe/issues/2608#issuecomment-1143169206
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2022 at 11:58:51 AM
- [x] show only doctors instead of all users ![image](https://user-images.githubusercontent.com/29787772/170483640-2536244a-a979-498b-8c33-ec40fd75da11.png)
https://github.com/coronasafe/care_fe/pull/2534#issuecomment-1138470859
Shared a comment on a pull request in coronasafe/care_fe on May 25, 2022 at 8:09:30 AM
As of now, we have 2 ways to access the notifications list, one is to use notification in the side menu bar and other is to use the floating icon, this is leading to an unexpected behavior of opening more than 1 notification list slideover at the same time i.e., when we click on floating icon, it opens 1 instance of the notifications list and we also can click on side menu bar to open another instance at the same time so, - [ ] create a global state for isNotificationsListOpen in AppRouter
https://github.com/coronasafe/care_fe/pull/2412#issuecomment-1136927596
<@U01JB8L8P7Y> has joined the channel
EOD 22/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Had a call with Swasth team to demo HCX flow in care • Fixed Cypress issues in facility_spec and resource_spec What's next? • Make a demo of M1 and M2 with recent changes • Help interview hub coordinator for Meghalaya • Follow up WASA certificate • Continue working on fixing cypress in sidelines
EOD 02/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go ? • Had usual weekly call with the team • Looked into cypress fails in <@U02TDGQQPMJ> phone component pr. • Clarified Bhavik Agarwal (from C4GT) questions about doctor notes. • Made a postman collections for WASA testing • Demoed ABDM to ACT along with <@U01196FB51P> and Raunauq • Merged a couple of minor prs what's next • Connect with Priyanka (from Allied Boston) to sort out blockers in WASA testing.
EOD 05/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go ? • Connected with Saurabh to understand where to get recipient-code from. • Made recipient-code dynamic • Had back and forth with WASA testing team on testing What's next • Work on <https://github.com/coronasafe/ayushma/issues/75>
EOD 07/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go ? • Added ABDM authentication class for callback APIs • Had a meeting with WASA testing team to walk them through the callback APIs What's next ! • Work on <https://github.com/coronasafe/ayushma/issues/75>
EOD 12/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Had a weekly call with the team • Worked with <@UPW6XDGDD> to remove nginx from error_pages • Went through few proposal dms • Reviewed and Merged tested prs What's next? • Work on <https://github.com/coronasafe/ayushma/issues/75> • Work on mui to tailwind
EOD 19/06/2023 <!subteam^S035L5S02RF|@care_engineering> how did the day go? • Had a weekly call with the team • Went through the tailwind prs • Planned out abdm folder structure for refactoring what's next • Complete <https://github.com/coronasafe/ayushma/issues/75> • Review and Merge tested prs • Checkout the issue in HCX • Work on ABDM refactor (unit tests and docs)
EOD 28/06/2023 <!subteam^S035L5S02RF|@care_engineering> how did the day go ? • Made a frontend pr for ayushma feedback (<https://github.com/coronasafe/ayushma_fe/pull/54>) • Merged latest master branch with abdm and fixed related issue (<@U02TB8XHZD1> helped out with conflicts in migration) • Reviewed and merged tested prs what's next ? • Merge latest develop branch with abdm in frontend • Look into unit tests for abdm
EOD 30/06/2023 How did the day go? • Merged latest develop branch with abdm-integration branch in frontend • Helped out <@U052CV9HBR6> with a positioning issue in <https://github.com/coronasafe/care_fe/pull/5719> • Resolved some merge conflicts and reviewed and merged remaining tested prs What's next? • Look into unit tests for abdm
EOD 10/07/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go ? • Worked on teleicu middleware to store past 30 min requests from all devices • Sat with HCX team and fixed issues in HCX FHIR bundle parsing What’s next • Review and Merge tested prs • Integrate the last 30min teleicu requests in care
EOD 17/07/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go ? • Reworked on suggestions by Shivank in <https://github.com/coronasafe/ayushma/issues/75> • Reviewed uptime pr What’s next ? • Review and merge the tested prs • Work on previously assigned issues